forked from 0xPolygonZero/plonky2
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support bn128 and circom #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cliff0412
changed the title
Dev cliff support bn128 and circom
support bn128 and circom
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR was to make the latest plonky2 support circom groth16 verification.
major changes are as below
[1] remove lookups
[2] Add public_inputs_hash interface and hash_public_inputs functions; as in cbn128 config, the public inputs are using PoseidonHahsh while the tree building using Poseidon128Hash; Use customised public_input_hash to use specific hash method.
[3] Add fn export_solidity_verification_code and export_solidity_verification_code to export circom verification code for each circuit
[4] Use low_degree_interpolation & high_degree_interpolation; the latest plonky2 use coset_interpolation
[5] quoticient_poly mul by x; refer to here: 0xPolygonZero#436
[6] rm self.write_usize(public_inputs.len())? in
write_proof_with_public_inputs
[7] latest plonky2 adds sereilizaiton & deserialization in the
Gate
trait; needs to add implementation for that, though currently it is not important[8] add poseidon_bn128 hash to support groth16 circom verification
Note:
an important reference is here datluongductuan/plonky2@3a5abe2