Implement control over circular associations #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okuramasafumi
force-pushed
the
circular_association
branch
from
b66d979 to
cfc0d72
Compare
* Exclude test code from Metrics cops * Let module length to be 150 lines long
okuramasafumi
force-pushed
the
circular_association
branch
from
cfc0d72 to
691b8c2
Compare
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
==========================================
+ Coverage 99.53% 99.56% +0.02%
==========================================
Files 7 7
Lines 217 228 +11
==========================================
+ Hits 216 227 +11
Misses 1 1
Continue to review full report at Codecov.
|
okuramasafumi
force-pushed
the
circular_association
branch
from
691b8c2 to
76e519e
Compare
|
Hmm, the last concern is the name. As proposed in #104 , JSON:API might be introduced in some future. JSON:API spec contains the reserved word "included", so it might be confusing to have |
The word `included` is used in JSON:API's Compound Documents, (see: https://jsonapi.org/format/#document-compound-documents) and we don't want to use it now since it's not related to JSON:API. We came up with the word `within` to replace `included` with.
okuramasafumi
force-pushed
the
circular_association
branch
from
9a5cf6a to
cfa9696
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.