Add jsonapi-serializer gem to benchmark and clean up the file #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I like your simple gem and that it includes a benchmark with various other gems. I was missing the jsonapi-serializers (formerly known as fast_jsonapi) gem and therefore I've added it. I've also added
benchmark/ips
and refactored the benchmark file (sorting calls and declarations alphabetically and adding some comments to make it simpler to understand the file).Ok, now you might wonder: "but jsonapi-serializers formats the output differently" and you would be correct. But as I've done in a few projects before, where some endpoints needed a simple, 'flat' serialization and didn't follow the JSON:API standard, I've overwritten its
as_json
method to get the same output as with the other serializers.And it is still fast, almost as fast as alba.
benchmark/ips output:
PS: I've got the idea from a tweet of @jgaskins who started to expand the benchmark (but didn't open a PR yet):
jgaskins@ad78703