Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test/spec] Failing spec tests for recursive arithmetic evaluations #686

Merged

Conversation

akinomyoga
Copy link
Collaborator

spec/ble-idioms.test.sh mentioned in #653 (comment).

@andychu
Copy link
Contributor

andychu commented Mar 31, 2020

Great thanks! It's interesting to see which shells support it, and as usual you find a bug or two :)

Since dash and yash don't support any of it, you can just delete the assertions and delete them from the arg list test/spec.sh. One reason for the different spec files is so each file can run on different shells. dash doesn't support most features that bash, mksh, etc. do.

@akinomyoga
Copy link
Collaborator Author

995e256 I removed dash and yash from test/spec.sh ble-idioms. I left the assertions of these shells because ble-idioms can possibly contain other tests unrelated to recursive arithmetic evaluations in future and dash and yash may be revisited then.

@andychu andychu merged commit 9fa3fa8 into oils-for-unix:master Mar 31, 2020
@akinomyoga akinomyoga deleted the add-tests-for-recursive-arith branch April 1, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants