Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read only reads a single line even with a different delimiter #694

Closed
Crestwave opened this issue Apr 7, 2020 · 1 comment
Closed

read only reads a single line even with a different delimiter #694

Crestwave opened this issue Apr 7, 2020 · 1 comment
Labels
pending-release

Comments

@Crestwave
Copy link
Contributor

Used by Neofetch.

osh$ read -rd '' var <<EOF
> foo
> bar
> EOF
osh$ echo "$var"
foo
$ read -rd '' var <<EOF
> foo
> bar
> EOF
$ echo "$var"
foo
bar
@Crestwave Crestwave mentioned this issue Apr 7, 2020
Closed
andychu pushed a commit that referenced this issue Apr 7, 2020
[builtin/read] Fix read -d behavior so that newline isn't special.
16bbec6 
Also fix the exit code when the delimiter isn't found.

Fixes issue #694.

Also refactor Oil's 'getline' builtin.
@andychu
Copy link
Contributor

andychu commented Apr 7, 2020 •
edited
Loading

Fixed. Good catch, thanks for testing!

@andychu andychu closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending-release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andychu @Crestwave