-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide a way to query the version #683
Comments
If Oil only supports a version string like |
I'm pretty sure we will stick with x.y.z, so it can be parsed with something like
(not tested) If we also have structured data, I think an associative array is better because you can add fields to it in a backward compatible way. |
I think the following points can be documented: Can we assume |
I think the algorithm for
On a related note, I think I may drop the "pre". In other words, right now the numbering scheme is:
But I discovered that people view "pre" as unstable, when in reality 0.8.pre3 is better than 0.7.0 in basically every way (due to all the tests we run.) Example of misconception: Homebrew/homebrew-core#51962 So I think the new numbering scheme can just be:
Which is basically what most projects do. I think I wanted to have a more meaningful concept of 0.7.0 and 0.8.0 but there's not enough user testing occurring for that to happen right now. (Either that or there are not enough Oil bugs, which is unlikely.) This also has the benefit that Since nobody should care about the dozens of That also gives some more runway before 1.0 :) If we want to maintain the Python style of avoiding 0.10, 1.10 and 2.10. So basically we will go
|
Well I guess the issue here is that we've never had a patch release. That is we've never had 0.6.1 or 0.7.1, etc. Python has such patches, but the Linux kernel doesn't I think. I was trying to be more like Python but so far that hasn't been necessary. |
I should also say that ble.sh and/or #663 are appealing because I would like Oil to change more slowly at some point in the future. That is, it is nice to write the interactive shell in shell/Oil and not Python/C++. There are likely to be many minor tweaks here and there that can go in a higher level, rather than the core. And that way the versioning of the core will be more stable. |
ble.sh and neofetch both want to use it. Addresses issue #683. Unrelated: Start QSTR doc.
$OIL_VERSION
=> 0.8.pre3BASH_VERSINFO
:I guess the reason to have it as an array is to do structured comparisons. That is
<
and>
for version numbers are nontrivial.But it does make sense to start with a string for POSIX shell compatibility, e.g. for a POSIX shell script that wants to query the version.
Requested on #653 for ble.sh, and I recall other people mentioning it too.
This is still relevant, although we're not being purists ...
https://github.com/oilshell/oil/wiki/Feature-Detection-Is-Better-than-Version-Detection
The text was updated successfully, but these errors were encountered: