Fixes #486 (#487)

* Fixes #486 * Don't use a list in changelog * Update CHANGELOG.md Co-authored-by: Andrew Vivash <[email protected]> Signed-off-by: Steven Vandevelde <[email protected]> --------- Signed-off-by: Steven Vandevelde <[email protected]> Co-authored-by: Andrew Vivash <[email protected]>
oddsdk · Feb 3, 2023 · d0ecd0a · d0ecd0a
1 parent 0e32247
commit d0ecd0a
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+### v0.36.1
+
+Fixes an issue with the CID log, which, in certain scenarios, caused Webnative to load the wrong version of an account's file system.
+
 ### v0.36.0
 
 #### Breaking changes

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "webnative",
-  "version": "0.36.0",
+  "version": "0.36.1",
   "description": "Webnative SDK",
   "keywords": [
     "WebCrypto",

diff --git a/src/common/version.ts b/src/common/version.ts
@@ -1,2 +1,2 @@
-export const VERSION = "0.36.0"
+export const VERSION = "0.36.1"
 export const WASM_WNFS_VERSION = "0.1.7"
diff --git a/src/filesystem.ts b/src/filesystem.ts
@@ -44,7 +44,7 @@ export async function loadFileSystem({ config, dependencies, eventEmitter, rootK
 
   // Determine the correct CID of the file system to load
   const dataCid = navigator.onLine ? await getDataRoot(reference, username, { maxRetries: 20 }) : null
-  const logIdx = dataCid ? cidLog.length() - cidLog.indexOf(dataCid) - 1 : -1
+  const logIdx = dataCid ? cidLog.indexOf(dataCid) : -1
 
   if (!navigator.onLine) {
     // Offline, use local CID
@@ -59,15 +59,16 @@ export async function loadFileSystem({ config, dependencies, eventEmitter, rootK
     if (cid) manners.log("📓 No DNSLink, using local CID:", cid.toString())
     else manners.log("📓 Creating a new file system")
 
-  } else if (logIdx === 0) {
+  } else if (logIdx === cidLog.length() - 1) {
     // DNS is up to date
     cid = dataCid
     manners.log("📓 DNSLink is up to date:", cid.toString())
 
-  } else if (logIdx > 0) {
+  } else if (logIdx !== -1 && logIdx < cidLog.length() - 1) {
     // DNS is outdated
     cid = cidLog.newest()
-    const idxLog = logIdx === 1 ? "1 newer local entry" : (cidLog.length() - logIdx - 1).toString() + " newer local entries"
+    const diff = cidLog.length() - 1 - logIdx
+    const idxLog = diff === 1 ? "1 newer local entry" : diff.toString() + " newer local entries"
     manners.log("📓 DNSLink is outdated (" + idxLog + "), using local CID:", cid.toString())
 
   } else {

diff --git a/src/repositories/cid-log.node.test.ts b/src/repositories/cid-log.node.test.ts
@@ -66,7 +66,7 @@ describe("cid-log", () => {
           const cid = cids[ idx ]
 
           // Get the index of test cid after all CIDs have been added
-          const index = await cidLog.indexOf(cid)
+          const index = cidLog.indexOf(cid)
 
           expect(index).toEqual(idx)
         })
@@ -85,7 +85,7 @@ describe("cid-log", () => {
           const cid = cids[ cids.length - 1 ]
 
           // Get the newest cid after all CIDs have been added
-          const newest = await cidLog.newest()
+          const newest = cidLog.newest()
 
           expect(newest.toString()).toEqual(cid.toString())
         })