Add verify with fallback #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| secret, | ||
| eventPayload, | ||
| signatureSHA256, | ||
| ["foo"] |
Check failure
Code scanning / CodeQL
Hard-coded credentials
|
|
||
| test("verifyWithFallback(bogus, eventPayload, signatureSHA256, [secret]) returns true", async () => { | ||
| const signatureMatches = await verifyWithFallback( | ||
| "foo", |
Check failure
Code scanning / CodeQL
Hard-coded credentials
|
|
||
| test("verify(bogus, eventPayload, signatureSHA256, [bogus]) returns false", async () => { | ||
| const signatureMatches = await verifyWithFallback( | ||
| "foo", |
Check failure
Code scanning / CodeQL
Hard-coded credentials
| "foo", | ||
| eventPayload, | ||
| signatureSHA256, | ||
| ["foo"] |
Check failure
Code scanning / CodeQL
Hard-coded credentials
|
Looks like this build is failing only due to a code formatting issue that can be easily resolved! |
This method wraps the (still exported) verify method.
nwf-msr
force-pushed
the
202302-verify-with-fallback
branch
from
ef3a10c to
0f66ee1
Compare
nickfloyd
approved these changes
Feb 21, 2023
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparatory work for a second attempt at octokit/webhooks.js#811 .
Behavior
See octokit/webhooks.js#770 and octokit/webhooks.js#811 .
Additional info
Pull request checklist
I am unable to add labels.
Does this introduce a breaking change?