Allow datetime.date for different localtime functions #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagdenaj
force-pushed
the
allow_date_in_serveral_localtime_functions
branch
2 times, most recently
from
9094bfd to
7f5cdb0
Compare
bagdenaj
force-pushed
the
allow_date_in_serveral_localtime_functions
branch
2 times, most recently
from
d61b9c7 to
bb8bd5c
Compare
This aims to make those functionss more flexible so that we avoid having to transforming dates into datetime before being able to pass them to those functions. Previously in our codebase this would look like this for exmaple: date = datetime.date(2024,7 ,9) start_of_month = localtime.start_of_month(localtime.midnight(date)) Now it gets shorter to just: date = datetime.date(2024,7 ,9) start_of_month = localtime.start_of_month(date)
bagdenaj
force-pushed
the
allow_date_in_serveral_localtime_functions
branch
from
bb8bd5c to
558b1cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the functions in the
localtimemodule insist ondatetime.datetimeinputs whendatetime.datealso works. This PR aims to make these functions more flexible to avoid things like: