Raised meaningful exceptions instead of assert statements #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raised meaningful exceptions instead of assert
samueljsb
reviewed
Mar 8, 2024
There was a problem hiding this comment.
Thanks for this contribution! It looks like you're our first contributor from a fork, so I think we need to fix some setting to make sure the tests run on this branch -- sorry for the delay while we sort that out.
Would you mind adding tests for this new behaviour, please? We'd also like to keep the commit history a bit cleaner, so if you could squash the commits into one that would be appreciated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes included in this PR are done with regards to this raised issue #85