Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide more useful information on ERROR: null #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

paulo-ocean
Copy link

Provide more useful info on the ERROR: null, while running tests

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, it's better than before

@paulo-ocean
Copy link
Author

paulo-ocean commented Dec 12, 2023

Yeah, better than nothing.. but not that good
from the .fail((msg, err, yargs) => {
we have the msg => null

on the err:
interface Error {
name: string;
message: string;
stack?: string;
}
name and message are "TypeError: Cannot convert object to primitive value" (What we know have with the change)

the stack is just empty

and the yargs is just the mocha run parameters from the config

Nothing about the file or the line of code that fails

@jamiehewitt15
Copy link
Member

Sounds like it would take a much bigger refactor to get the stack trace

@paulo-ocean
Copy link
Author

yeah, honestly, i'm not even sure where that refactor would have to go..
these functions used here come from https://github.com/yargs/yargs/
its like going down the rabbit hole... but how deep is that hole? :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants