Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mock data): failed to cancel the mock data task #2850

Merged

Conversation

zijiacj
Copy link
Collaborator

@zijiacj zijiacj commented Jun 28, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@zijiacj zijiacj added type-bug Something isn't working module-Mock data labels Jun 28, 2024
@zijiacj zijiacj added this to the ODC 4.3.1 milestone Jun 28, 2024
@zijiacj zijiacj self-assigned this Jun 28, 2024
@zijiacj zijiacj requested review from yhilmare and krihy as code owners June 28, 2024 10:25
@yhilmare yhilmare changed the title fix(mock data):optimize error message when cancelling mockdata ticket fix(mock data): optimize error message when cancelling mockdata ticket Jul 1, 2024
@zijiacj zijiacj force-pushed the fix/optimize_error_message_when_cancelling_mockdata_ticket branch from e60f136 to 612b51e Compare July 3, 2024 02:01
@zijiacj zijiacj force-pushed the fix/optimize_error_message_when_cancelling_mockdata_ticket branch from 57c12f9 to cfcd699 Compare July 3, 2024 03:57
yhilmare
yhilmare previously approved these changes Jul 3, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Jane201510
Jane201510 previously approved these changes Jul 3, 2024
@zijiacj zijiacj dismissed stale reviews from Jane201510 and yhilmare via 1b1bccf July 3, 2024 13:15
@zijiacj zijiacj changed the title fix(mock data): optimize error message when cancelling mockdata ticket fix(mock data): use synchronized to ensure that context is present when canceling mock data ticket Jul 3, 2024
@zijiacj zijiacj force-pushed the fix/optimize_error_message_when_cancelling_mockdata_ticket branch from 1b1bccf to 66cf6e5 Compare July 3, 2024 13:27
@yhilmare yhilmare changed the title fix(mock data): use synchronized to ensure that context is present when canceling mock data ticket fix(mock data): failed to cancel the mock data task Jul 4, 2024
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 1f623b7 into dev/4.3.x Jul 4, 2024
7 checks passed
@yhilmare yhilmare deleted the fix/optimize_error_message_when_cancelling_mockdata_ticket branch July 4, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Mock data type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants