-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mock data): failed to cancel the mock data task #2850
Merged
yhilmare
merged 12 commits into
dev/4.3.x
from
fix/optimize_error_message_when_cancelling_mockdata_ticket
Jul 4, 2024
Merged
fix(mock data): failed to cancel the mock data task #2850
yhilmare
merged 12 commits into
dev/4.3.x
from
fix/optimize_error_message_when_cancelling_mockdata_ticket
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhilmare
reviewed
Jul 1, 2024
...c-service/src/main/java/com/oceanbase/odc/service/flow/task/MockDataRuntimeFlowableTask.java
Outdated
Show resolved
Hide resolved
yhilmare
changed the title
fix(mock data):optimize error message when cancelling mockdata ticket
fix(mock data): optimize error message when cancelling mockdata ticket
Jul 1, 2024
zijiacj
requested review from
Jane201510,
JessieWuJiexi and
yizhouxw
as code owners
July 2, 2024 15:48
zijiacj
force-pushed
the
fix/optimize_error_message_when_cancelling_mockdata_ticket
branch
from
July 3, 2024 02:01
e60f136
to
612b51e
Compare
zijiacj
force-pushed
the
fix/optimize_error_message_when_cancelling_mockdata_ticket
branch
from
July 3, 2024 03:57
57c12f9
to
cfcd699
Compare
yhilmare
reviewed
Jul 3, 2024
server/odc-core/src/main/resources/i18n/BusinessMessages_zh_TW.properties
Outdated
Show resolved
Hide resolved
...c-service/src/main/java/com/oceanbase/odc/service/flow/task/MockDataRuntimeFlowableTask.java
Outdated
Show resolved
Hide resolved
yhilmare
reviewed
Jul 3, 2024
server/odc-core/src/main/java/com/oceanbase/odc/core/shared/constant/ErrorCodes.java
Outdated
Show resolved
Hide resolved
server/odc-core/src/main/resources/i18n/ErrorMessages_zh_CN.properties
Outdated
Show resolved
Hide resolved
...c-service/src/main/java/com/oceanbase/odc/service/flow/task/MockDataRuntimeFlowableTask.java
Outdated
Show resolved
Hide resolved
yhilmare
previously approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Jane201510
previously approved these changes
Jul 3, 2024
zijiacj
changed the title
fix(mock data): optimize error message when cancelling mockdata ticket
fix(mock data): use synchronized to ensure that context is present when canceling mock data ticket
Jul 3, 2024
zijiacj
force-pushed
the
fix/optimize_error_message_when_cancelling_mockdata_ticket
branch
from
July 3, 2024 13:27
1b1bccf
to
66cf6e5
Compare
yhilmare
changed the title
fix(mock data): use synchronized to ensure that context is present when canceling mock data ticket
fix(mock data): failed to cancel the mock data task
Jul 4, 2024
yhilmare
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
yizhouxw
approved these changes
Jul 4, 2024
JessieWuJiexi
approved these changes
Jul 4, 2024
Jane201510
approved these changes
Jul 4, 2024
yhilmare
deleted the
fix/optimize_error_message_when_cancelling_mockdata_ticket
branch
July 4, 2024 07:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: