-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dlm): incremenntal table structure synchronization #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructure comparator.
guowl3
requested review from
yhilmare,
krihy,
yizhouxw and
smallsheeeep
as code owners
April 11, 2024 03:53
yizhouxw
changed the title
feat(dlm):synchronize the table structure
feat(dlm): incremenntal table structure synchronization
Apr 15, 2024
yizhouxw
reviewed
Apr 15, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/job/DLMJobParameters.java
Outdated
Show resolved
Hide resolved
smallsheeeep
suggested changes
May 8, 2024
...r/odc-service/src/main/java/com/oceanbase/odc/service/dlm/DLMTableStructureSynchronizer.java
Outdated
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/task/executor/task/DataArchiveTask.java
Show resolved
Hide resolved
smallsheeeep
approved these changes
May 15, 2024
krihy
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
yhilmare
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
What this PR does / why we need it:
Synchronize the table structure based on the results from the table structure comparator. After this PR is merged, DLM tasks will support automatic table structure synchronization for both MYSQL and OB data sources.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: