Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(object-search): persistence and service layer implementation #2155

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

smallsheeeep
Copy link
Contributor

@smallsheeeep smallsheeeep commented Apr 3, 2024

What type of PR is this?

type-feature
module-Database object management

What this PR does / why we need it:

ODC will support global database object search in 4.3.0. This PR add the persisitence layer and service layer implementation codes.

  1. V_4_3_0_2__add_object_search.sql : add two table database_schema_object and database_schema_column for recording all database objects and columns.
  2. DBObjectIndexController : add two API for search DB objects and initiate a synchronized task.
  3. DBObjectIndexService : is the related service codes. The search DB objects API is still implemented and unit test has covered. The DB object synchronized task codes will be completed in the next PR.

Which issue(s) this PR fixes:

#1835

Special notes for your reviewer:

Unit tests covered.

Additional documentation e.g., usage docs, etc.:


@smallsheeeep smallsheeeep added type-feature The functionality to be implemented priority-medium module-Database object Table/View/Type/Function/Procedure/Package/Synonym/Constraint/Index labels Apr 3, 2024
@smallsheeeep smallsheeeep added this to the ODC 4.3.0 milestone Apr 3, 2024
@smallsheeeep smallsheeeep self-assigned this Apr 3, 2024
@smallsheeeep smallsheeeep marked this pull request as ready for review April 3, 2024 10:55
yizhouxw
yizhouxw previously approved these changes Apr 12, 2024
Copy link
Contributor

@yizhouxw yizhouxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smallsheeeep smallsheeeep requested a review from yhilmare April 15, 2024 06:49
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@LuckyPickleZZ LuckyPickleZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PeachThinking PeachThinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhilmare yhilmare merged commit f4e5e31 into dev/4.3.x Apr 15, 2024
11 checks passed
@yhilmare yhilmare deleted the feat/gaoda_43x_db_object_persistence_and_service branch April 15, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module-Database object Table/View/Type/Function/Procedure/Package/Synonym/Constraint/Index priority-medium type-feature The functionality to be implemented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants