-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(object-search): persistence and service layer implementation #2155
feat(object-search): persistence and service layer implementation #2155
Conversation
server/odc-migrate/src/main/resources/migrate/common/V_4_3_0_2__add_object_search.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
server/odc-service/src/main/java/com/oceanbase/odc/metadb/dbobject/DBColumnRepository.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/connection/ConnectionService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/schema/DBSchemaIndexService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/schema/DBSchemaIndexService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/schema/DBSchemaIndexService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/schema/DBSchemaIndexService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/schema/DBSchemaIndexService.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/schema/model/OdcDBColumn.java
Show resolved
Hide resolved
server/odc-service/src/main/java/com/oceanbase/odc/service/db/schema/model/OdcDBObject.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
type-feature
module-Database object management
What this PR does / why we need it:
ODC will support global database object search in 4.3.0. This PR add the persisitence layer and service layer implementation codes.
V_4_3_0_2__add_object_search.sql
: add two tabledatabase_schema_object
anddatabase_schema_column
for recording all database objects and columns.DBObjectIndexController
: add two API for search DB objects and initiate a synchronized task.DBObjectIndexService
: is the related service codes. The search DB objects API is still implemented and unit test has covered. The DB object synchronized task codes will be completed in the next PR.Which issue(s) this PR fixes:
#1835
Special notes for your reviewer:
Unit tests covered.
Additional documentation e.g., usage docs, etc.: