Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session): failed to remove session when session is expired #2125

Merged
merged 7 commits into from
Apr 1, 2024

Conversation

yhilmare
Copy link
Contributor

@yhilmare yhilmare commented Apr 1, 2024

What type of PR is this?

type-bug

What this PR does / why we need it:

  1. this pr fix an issue that a session will not be removed when it is expired.
  2. there is a security risk attached to horizontal ultra vires

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@yhilmare yhilmare added the type-bug Something isn't working label Apr 1, 2024
@yhilmare yhilmare added this to the ODC 4.2.4 milestone Apr 1, 2024
@yhilmare yhilmare self-assigned this Apr 1, 2024
Copy link
Collaborator

@MarkPotato777 MarkPotato777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@LuckyPickleZZ LuckyPickleZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit efde492 into dev/4.2.x Apr 1, 2024
13 checks passed
@yhilmare yhilmare deleted the fix/shanlu_fix_session_management branch April 1, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants