fix(resultset-edit): bad performance when modifing query result set #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallsheeeep
requested review from
yhilmare,
yizhouxw,
LuckyPickleZZ and
PeachThinking
as code owners
LuckyPickleZZ
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
module-resultset
What this PR does / why we need it:
When I update 100 rows and 1 column in the result set, then ODC will cost about 16.5 second. The root cause is that the
UpdateGeneratorhas repeated SQL query. This PR fix it and the time elapsed decrease to about 700ms.Which issue(s) this PR fixes:
Fixes #2005
Special notes for your reviewer:
Self-test passed
Additional documentation e.g., usage docs, etc.: