Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db-browser): the order of column names in Index and constraint are inconsistent #1948

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

PeachThinking
Copy link
Collaborator

What type of PR is this?

type-bug

What this PR does / why we need it:

  1. fix the order of column names in Index and constraint are inconsistent
  2. fix display package body even when there is no package body in the native Oracle package

Which issue(s) this PR fixes:

Fixes #1942
Fixes #1895

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:


@PeachThinking PeachThinking requested a review from yhilmare as a code owner March 18, 2024 11:23
@yhilmare yhilmare added the type-bug Something isn't working label Mar 18, 2024
@yhilmare yhilmare added this to the ODC 4.2.4 milestone Mar 18, 2024
@yhilmare yhilmare changed the title fix(db-browser):the order of column names in Index and constraint are inconsistent fix(db-browser): the order of column names in Index and constraint are inconsistent Mar 18, 2024
@PeachThinking PeachThinking force-pushed the fix/jingtina_424_show_package_error branch from d95b88b to 824b536 Compare March 18, 2024 13:17
Copy link
Contributor

@smallsheeeep smallsheeeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 6e56778 into dev/4.2.x Mar 19, 2024
13 checks passed
@yhilmare yhilmare deleted the fix/jingtina_424_show_package_error branch March 19, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants