Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catala.0.7.0: remvove references to dev variables #21996

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

AltGr
Copy link
Member

@AltGr AltGr commented Aug 17, 2022

There is apparently a bad interaction with opam's current --strict option. These variables are used as a workaround for the
lack of the forthcoming --for-dev flag. We'll need to remember to filter out these variables from the in-source opam file when publishing the next versions of the package.

There is apparently a bad interaction with opam's current --strict option. These variables are used as a workaround for the
lack of the forthcoming --for-dev flag. We'll need to remember to filter out these variables from the in-source opam file when publishing the next versions of the package.
@AltGr
Copy link
Member Author

AltGr commented Aug 17, 2022

it's weird that it's --strict and not opam lint that is failing on this though. Probably worth having a look into how it's done in opam.

@kit-ty-kate
Copy link
Member

There is apparently a bad interaction with opam's current --strict option

I find this rather weird. We're also using --strict with opam 2.0, 2.1 and 2.2 in CI on the whole repository and never had any issue about those variables

@kit-ty-kate
Copy link
Member

It looks like a bug in opam: ocaml/opam#5248

This PR is fine as-is, however there is the more general issue of: we'll have to do the same exact thing for the new for-dev variable in opam 2.2, which is quite sad.

Oh well. Thanks anyway!

@kit-ty-kate kit-ty-kate merged commit 39fe9fb into ocaml:master Aug 17, 2022
@na4zagin3
Copy link
Contributor

Thank you all for addressing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants