Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations: Update translations with latest from crowdin #636

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

tt2468
Copy link
Member

@tt2468 tt2468 commented Dec 20, 2020

Description

Update various translation files with latest approved translations

Motivation and Context

Just approved a bunch of new translations, and removed outdated translations for OBSWebsocket.Server.StartFailed.Message

How Has This Been Tested?

Tested OS(s): n/a

Types of changes

  • Enhancement (modification to a current event/request which adds functionality)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@zgero
Copy link

zgero commented Dec 24, 2020

Is there any issue with Korean Translation? Crowdin has approved translation but why dropped in this PR?

@tt2468
Copy link
Member Author

tt2468 commented Dec 24, 2020

@zgero The changes here are directly downloaded from crowdin's export feature. However I see that many translations have been suggested so I will update this PR.

@tt2468 tt2468 force-pushed the enhancement/latest-translations branch from eba89b4 to ba143f2 Compare December 24, 2020 21:28
@tt2468
Copy link
Member Author

tt2468 commented Dec 24, 2020

Found the issue. I forgot to build the latest translations.

Copy link

@zgero zgero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double Check with Google Translation & Naver Papago.

…lations

For some reason crowdin included it even though it is not approved.
The current unapproved translation uses the old string.
@tt2468 tt2468 force-pushed the enhancement/latest-translations branch from 81aee34 to 7e0874a Compare January 8, 2021 12:57
@Palakis Palakis merged commit 853eeb2 into 4.x-current Jan 18, 2021
@Palakis Palakis added this to the 4.9 milestone Jan 18, 2021
@tt2468 tt2468 deleted the enhancement/latest-translations branch January 18, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants