-
-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] Reenable building with captions on MacOS #546
[Bug Fix] Reenable building with captions on MacOS #546
Conversation
OBS on MacOS supports closed caption encoding. The Windows-only dependencies [here](https://github.com/obsproject/obs-studio/blob/master/UI/frontend-plugins/frontend-tools/CMakeLists.txt#L73) are only related to audio capture, not closed caption encoding.
If captions are already included regardless of the CMake file, then wouldn't it also support linux too? |
I don't have an environment where I can test Linux support at the moment, but on the MacOS side it definitely appears to work. |
Tested myself on ubuntu, works great. Merging this since there is nothing to change for Ubuntu. |
@tt2468 Thank you! Any chances for a point release? I'm looking to use this in an app soon and it will simplify instructions if I don't need to explain to users how to build this on their own if they're on MacOS. |
You can download your pr's macos artifact here, which should include an installer https://dev.azure.com/Palakis/2687c5e1-1f5c-4326-8080-85cbdf4f4033/_apis/build/builds/1288/artifacts?artifactName=macos_build&api-version=5.1&%24format=zip |
Is this related to the issue I opened here ? #617 If so, How do I fix this? |
@arisprung Yes it is! |
@arisprung You can fetch a fresh build of the dev branch here: https://dev.azure.com/Palakis/obs-websocket/_build/results?buildId=1438&view=artifacts&pathAsName=false&type=publishedArtifacts |
There is a download arrow on the right side of the row if you hover over it |
This reverts #477. OBS on MacOS supports closed caption encoding. The Windows-only dependencies here are only related to audio capture, not closed caption encoding.
OBS Studio 25.0.8 and latest version of obs-websocket 4.x built with
BUILD_CAPTIONS=true
receiving an event originating from obs-websocket-js:Closed captions appearing in Twitch stream: