Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: sync-to-xlog #2547

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

Otto-J
Copy link
Contributor

@Otto-J Otto-J commented Oct 16, 2023

I am submitting a new Community Plugin

Repo URL

Link to my plugin:

https://github.com/Otto-J/sync-to-xlog

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@github-actions github-actions bot changed the title Add sync-to-xlog plugin Add plugin: sync-to-xlog Oct 16, 2023
@Otto-J Otto-J changed the title Add plugin: sync-to-xlog Add Plugin sync-to-xlog Oct 16, 2023
@Otto-J Otto-J changed the title Add Plugin sync-to-xlog Add Plugin: sync-to-xlog Oct 16, 2023
@Otto-J Otto-J changed the title Add Plugin: sync-to-xlog Add plugin: sync-to-xlog Oct 16, 2023
@joethei
Copy link
Collaborator

joethei commented Oct 20, 2023

Please follow the pull request template.

@Otto-J
Copy link
Contributor Author

Otto-J commented Oct 22, 2023

Please follow the pull request template.

Sure. Done.

@joethei
Copy link
Collaborator

joethei commented Oct 23, 2023

Copyright (c) [year] [fullname]
Please fill this

"description": "A plugin let you sync your obsidian vault with xlog",
We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple.
Avoid including sentences like "A plugin that does ..." in your description.

SampleSettingTab
Rename this class.

onst addOrUpdateFrontMatter = async (obj: Record<string, string>) => {
Use the processFrontmatter function instead: https://github.com/obsidianmd/obsidian-api/blob/master/CHANGELOG.md#new-metadata-api

const response = await fetch(
Use the requestUrl function from the Obsidian API instead, it will handle some things like CORS automatically.

export const http = axios.create({
Same here,

Obsidian Sync Xlog


Don't include a header with the plugin name in the settings

console.log("save");
Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

@joethei joethei self-assigned this Oct 23, 2023
@joethei joethei added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Oct 23, 2023
@Otto-J
Copy link
Contributor Author

Otto-J commented Oct 24, 2023

Sure. Working in progress:

  • MIT text fill
  • change desc
  • rename settingtab
  • change frontmatter code
  • use requeseturl,remove axios and fetch
  • remove setting heading text
  • remove useless console

@Otto-J
Copy link
Contributor Author

Otto-J commented Oct 24, 2023

@Otto-J
Copy link
Contributor Author

Otto-J commented Nov 1, 2023

Copyright (c) [year] [fullname] Please fill this

"description": "A plugin let you sync your obsidian vault with xlog", We have published a guide for plugin descriptions to follow here: https://docs.obsidian.md/Plugins/Releasing/Submission+requirements+for+plugins#Keep+plugin+descriptions+short+and+simple. Avoid including sentences like "A plugin that does ..." in your description.

SampleSettingTab Rename this class.

onst addOrUpdateFrontMatter = async (obj: Record<string, string>) => { Use the processFrontmatter function instead: https://github.com/obsidianmd/obsidian-api/blob/master/CHANGELOG.md#new-metadata-api

const response = await fetch( Use the requestUrl function from the Obsidian API instead, it will handle some things like CORS automatically.

export const http = axios.create({ Same here,

Obsidian Sync Xlog

Don't include a header with the plugin name in the settings
console.log("save"); Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during development.

Done. Can you review agigin?I think it is better than before.

@joethei joethei added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Nov 3, 2023
@liamcain liamcain merged commit d3cd8dc into obsidianmd:master Nov 7, 2023
1 check passed
@Otto-J Otto-J deleted the feature/add-sync-to-xlog branch November 8, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants