Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaded Android Gradle Plugin conditionally #1129

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Loaded Android Gradle Plugin conditionally #1129

merged 1 commit into from
Feb 24, 2020

Conversation

SaeedZhiany
Copy link
Contributor

  • Loaded Android Gradle Plugin conditionally

This wraps the Android Gradle plugin dependency in the buildscripts section of android/build.gradle in a conditional:

if (project == rootProject) {
    // ... (dependency here)
}

The Android Gradle plugin is only required when opening the project stand-alone, not when it is included as a dependency. By doing this, the project opens correctly in Android Studio, and it can also be consumed as a native module dependency from an application project without affecting the app project (avoiding unnecessary downloads/conflicts/etc).

for more info, you can refer to this thread and especially this comment.

  • fixed some configuration to match with other RN libraries

And fixed some configuration to match with other RN libraries
@SaeedZhiany SaeedZhiany requested a review from oblador February 10, 2020 09:36
@oblador oblador merged commit d0d6fbd into oblador:master Feb 24, 2020
@SaeedZhiany SaeedZhiany deleted the patch-1 branch February 24, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants