Switch dump validators to Nexus #2102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
6 tasks
buberdds
commented
Dec 5, 2024
| }, | ||
| node_id: 'SQZZd1wsWXdFsqswUoh6hZtmzu+ejuSnrGeHtgIBJDo=', | ||
| rank: 2, | ||
| start_date: '2024-04-11T03:43:47Z', |
There was a problem hiding this comment.
Changes in API binding can be removed when start_date is removed from mocks, but I think it's worth keeping more valid bindings anyway. With old types Nexus date-time strings are mark as Date objects which is not true, these props are strings in API.
edit: will extract to another PR
buberdds
commented
Dec 5, 2024
| @@ -207,8 +251,8 @@ describe('Staking Sagas', () => { | |||
| list: parseValidatorsList( | |||
| getMainnetDumpValidatorsMock.list.map(({ _expectedStatus, ...v }) => ({ | |||
There was a problem hiding this comment.
Test is passing, but I am not 100% sure about this. Test implements logic that is in saga?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for #2086