Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filename required in AttachmentBuilder #546

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Make filename required in AttachmentBuilder #546

merged 1 commit into from
Sep 16, 2023

Conversation

abitofevrything
Copy link
Member

Description

Closes #536

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Ran dart analyze or make analyze and fixed all issues
  • Ran dart format --set-exit-if-changed -l 160 ./lib or make format and fixed all issues
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@abitofevrything abitofevrything added the bug Something isn't working label Sep 16, 2023
@abitofevrything abitofevrything added this to the 6.0 milestone Sep 16, 2023
@abitofevrything abitofevrything self-assigned this Sep 16, 2023
@abitofevrything abitofevrything linked an issue Sep 16, 2023 that may be closed by this pull request
AttachmentBuilder.fileName should not be optional. #536
Closed
@abitofevrything abitofevrything merged commit bfbe4e5 into next Sep 16, 2023
7 checks passed
@abitofevrything abitofevrything deleted the bug/attachment-builder-required-filename branch September 16, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l7ssha l7ssha l7ssha approved these changes

Assignees

@abitofevrything abitofevrything

Labels
bug Something isn't working
Projects
No open projects
nyxx roadmap
Status: Done
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

AttachmentBuilder.fileName should not be optional.
2 participants
@abitofevrything @l7ssha