Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(monorepo): put deps in root #93

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

shinGangan
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

It's about package management that I was talking about in this comment.

Copy link

vercel bot commented Jun 12, 2024

@shinGangan is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@shinGangan
Copy link
Contributor Author

shinGangan commented Jun 12, 2024

This PR is low priority.
Please review when you have a time πŸ™

@harlan-zw
Copy link
Collaborator

Thanks!

@harlan-zw harlan-zw merged commit ea67ddb into nuxt:main Jun 13, 2024
1 of 3 checks passed
@shinGangan
Copy link
Contributor Author

Question

@harlan-zw

Is it okay to manage clinet/ in the same way?
I thought it would be better to separate it if there are separate npm releases etc., but if I'm mistaken, I'll manage it in the same way.

@shinGangan shinGangan deleted the chore/fix-monorepo-deps branch June 14, 2024 02:01
@harlan-zw
Copy link
Collaborator

They wouldn't have separate releases, I set it up like this based on Nuxt Fonts repo.

Happy to review anything changes you want to make though

@shinGangan
Copy link
Contributor Author

Thanks for your comments. πŸ’š
I will respond and create PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants