Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refactor script setup lang="ts" #116

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

shinGangan
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Since <script setup lang="ts"> and <script lang="ts" setup> were mixed, we unified them to <script setup lang="ts">.

Copy link

vercel bot commented Jun 27, 2024

@shinGangan is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@shinGangan
Copy link
Contributor Author

This PR only supports docs/ because it will affect the PRs currently being created.
After the current feature PR is merged, I will refactor the other directories (src/, client/, playground/) as well.

@shinGangan
Copy link
Contributor Author

This PR isn't a feature development so it has a low review priority. πŸ™

@harlan-zw
Copy link
Collaborator

Great love these small details!

@harlan-zw harlan-zw merged commit 565211e into nuxt:main Jun 28, 2024
1 of 3 checks passed
@shinGangan shinGangan deleted the docs/fix-script-setup branch June 28, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants