Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: access experimental config from public key #2005

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix: access experimental config from public key #2005

merged 1 commit into from
Apr 13, 2023

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We recently deprecated a Nuxt 2 compatibility feature (nuxt/nuxt#20082) and it seems that @nuxt/content was still using this feature.

(We plan to remove it entirely by v3.5.)

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 12, 2023
@danielroe danielroe requested a review from farnabaz April 12, 2023 14:10
@danielroe danielroe self-assigned this Apr 12, 2023
@codesandbox
Copy link

codesandbox bot commented Apr 12, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-content canceled.

Name Link
🔨 Latest commit 5ead1bb
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-content/deploys/6436bbc5123b6000080022d4

farnabaz
farnabaz approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@farnabaz farnabaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@farnabaz farnabaz merged commit bd1cbb4 into main Apr 13, 2023
@farnabaz farnabaz deleted the fix/public-config branch April 13, 2023 09:36
@farnabaz farnabaz mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farnabaz farnabaz farnabaz approved these changes

Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @farnabaz