Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): respect environment variable preset overrides #514

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Eazash
Copy link
Contributor

@Eazash Eazash commented Oct 15, 2024

πŸ”— Linked issue

Resolves #513

resolves nuxt/nuxt#29525

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR ensures that the NITRO_PRESET and SERVER_PRESET environment variables are passed to nuxt kit for nitro overrides. It also follows the same order of priority as nitro (i.e. cli argument -> NITRO_PRESET -> SERVER_PRESET)

@Eazash Eazash requested a review from danielroe as a code owner October 15, 2024 16:30
@danielroe danielroe requested a review from pi0 October 15, 2024 17:14
@danielroe danielroe merged commit 4c9047c into nuxt:main Oct 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants