Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): prepend baseURL for vite hmr ws upgrade #370

Merged
merged 3 commits into from
Mar 20, 2024
Merged

fix(dev): prepend baseURL for vite hmr ws upgrade #370

merged 3 commits into from
Mar 20, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Mar 20, 2024

This was causing errors for apps with custom baseUrl and making dev server non-usable at all

Screenshot 2024-03-19 at 21 00 53

@antfu antfu added the bug Something isn't working label Mar 20, 2024
src/utils/dev.ts Outdated Show resolved Hide resolved
src/utils/dev.ts Show resolved Hide resolved
@pi0 pi0 changed the title fix: consider baseURL for ws upgrade fix(dev): prepend baseURL for vite hmr ws upgrade Mar 20, 2024
@pi0 pi0 merged commit b6ca41b into main Mar 20, 2024
2 checks passed
@pi0 pi0 deleted the fix/ws-base branch March 20, 2024 08:35
@qyd159
Copy link

qyd159 commented May 14, 2024

when i set baseURL as './', this error still occurs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants