Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix numaflow-rs binary location in image #2050

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Sep 10, 2024

This download action was downloading the numaflow-rs-linux-amd64 binary into dist/numaflow-rs-linux-amd64/numaflow-rs-linux-amd64.

- name: Download Rust amd64 binaries
  uses: actions/download-artifact@v3
  with:
    name: numaflow-rs-linux-amd64
    path: dist/numaflow-rs-linux-amd64

This results in the Rust binary to be /bin/numaflow-rs/numaflow-rs-linux-amd64 instead of /bin/numaflow-rs.

@BulkBeing BulkBeing mentioned this pull request Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.18%. Comparing base (ba40b15) to head (e042ec9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2050      +/-   ##
==========================================
- Coverage   63.42%   63.18%   -0.24%     
==========================================
  Files         319      319              
  Lines       29171    29171              
==========================================
- Hits        18501    18431      -70     
- Misses       9658     9728      +70     
  Partials     1012     1012              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BulkBeing BulkBeing changed the title fix: Debug rust binary location in image fix: Fix numaflow-rs binary location in image Sep 10, 2024
@BulkBeing BulkBeing marked this pull request as ready for review September 10, 2024 15:20
@vigith vigith merged commit 0811eb4 into main Sep 10, 2024
35 checks passed
@vigith vigith deleted the dev-nightly-rust-binary branch September 10, 2024 15:27
whynowy pushed a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants