Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce readyReplicas for Vertex and MonoVertex #2014

Merged
merged 4 commits into from
Aug 30, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 30, 2024

  1. Enabled meaningful readiness check for Vertex and MonoVertex pods, to tell if the pod is ready to take traffic.
  2. Introduced readyReplicas in the status fields, that will be used to do more accurate autoscaling - do not want to do it in this PR even though it's a small change, let the CRD change out first.

Enhancement for readiness check on each sidecar: #2015.

Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy requested a review from vigith as a code owner August 30, 2024 00:24
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 61.31%. Comparing base (ee8b83a) to head (6e3a51a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/metrics/metrics_server.go 0.00% 6 Missing ⚠️
pkg/reconciler/monovertex/controller.go 0.00% 5 Missing ⚠️
pkg/reconciler/vertex/controller.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2014      +/-   ##
==========================================
+ Coverage   61.07%   61.31%   +0.23%     
==========================================
  Files         317      317              
  Lines       28375    28396      +21     
==========================================
+ Hits        17331    17411      +80     
+ Misses      10098    10038      -60     
- Partials      946      947       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whynowy whynowy merged commit 35c6f09 into numaproj:main Aug 30, 2024
25 checks passed
@whynowy whynowy deleted the ready branch August 30, 2024 02:42
whynowy added a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants