Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use kube_codegen.sh instead in codegen. #2011

Merged
merged 2 commits into from
Sep 5, 2024
Merged

chore: use kube_codegen.sh instead in codegen. #2011

merged 2 commits into from
Sep 5, 2024

Conversation

xdevxy
Copy link
Contributor

@xdevxy xdevxy commented Aug 29, 2024

make codegen has the following warning,

WARNING: generate-internal-groups.sh is deprecated.
WARNING: Please use k8s.io/code-generator/kube_codegen.sh instead.

which can cause similar permission denied issue as numaproj/numaplane#214

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.83%. Comparing base (8fc99bb) to head (3c55904).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
- Coverage   61.85%   61.83%   -0.03%     
==========================================
  Files         318      318              
  Lines       28979    28979              
==========================================
- Hits        17924    17918       -6     
- Misses      10098    10114      +16     
+ Partials      957      947      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kohlisid
Copy link
Contributor

Hey @xdevxy
Just curios did any other things change along with the script if you have taken a look into that?
Otherwise I would do a spike on that just to understand the transition a bit better

@xdevxy xdevxy marked this pull request as ready for review September 5, 2024 22:35
@xdevxy xdevxy merged commit 9f13068 into main Sep 5, 2024
25 checks passed
@xdevxy xdevxy deleted the codegen-fix branch September 5, 2024 22:35
whynowy pushed a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants