Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not pass scale info to MonoVertex #1990

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 22, 2024

Fix: #1988

@whynowy whynowy requested a review from vigith as a code owner August 22, 2024 00:52
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.15%. Comparing base (b72be93) to head (bac4bc2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
+ Coverage   53.57%   54.15%   +0.58%     
==========================================
  Files         286      286              
  Lines       22319    22321       +2     
==========================================
+ Hits        11957    12088     +131     
+ Misses       9421     9285     -136     
- Partials      941      948       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whynowy whynowy merged commit 6918e6f into numaproj:main Aug 22, 2024
25 checks passed
@whynowy whynowy deleted the fixxx branch August 22, 2024 02:26
whynowy added a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changing scale is causing pod recreation
2 participants