Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mono vertex UI #1941

Merged
merged 7 commits into from
Aug 16, 2024
Merged

feat: Mono vertex UI #1941

merged 7 commits into from
Aug 16, 2024

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Aug 14, 2024

Fixes: #1923

  • Update pipeline count and status - in summary bar and cards - for Cluster and Namespace page
  • Fixed filtering and sorting for MonoVertex with the Pipelines
  • Added filtering for K8S events for MonoVertex in Namespace page
  • Disabled CRUD through UI for MonoVertex
  • Added new route for monoVertex graph page - /?namespace=<name>&pipeline=<name>&type=monoVertex
  • Processing rate w/o partition for monoVertex
image image

TODO: Health Status once available

veds-g added 2 commits August 14, 2024 11:58
Signed-off-by: veds-g <[email protected]>
Signed-off-by: veds-g <[email protected]>
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.73%. Comparing base (9e96386) to head (c85aa8e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1941      +/-   ##
==========================================
+ Coverage   57.44%   57.73%   +0.29%     
==========================================
  Files         412      412              
  Lines       28789    28789              
==========================================
+ Hits        16537    16621      +84     
+ Misses      11307    11224      -83     
+ Partials      945      944       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veds-g veds-g marked this pull request as ready for review August 15, 2024 11:24
@veds-g veds-g requested review from whynowy and vigith as code owners August 15, 2024 11:24
@veds-g veds-g requested a review from mshakira August 15, 2024 12:43
pipelineId={pipelineId}
vertexId={vertexId}
pipelineId={
type === "monoVertex" ? `${pipelineId} (MonoVertex)` : pipelineId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets create variable for monoVertex

@KeranYang
Copy link
Member

Hey @veds-g , Yashash and I just made changes to our e2e tests and committed to the main. If you continue working on your branch, you might see some un-expected e2e testing failures. To fix them, please rebase. Thanks!

@mshakira mshakira merged commit c14abd5 into numaproj:main Aug 16, 2024
25 checks passed
KeranYang pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI to display MonoVertex
3 participants