Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use same server-info file for all map modes #1828

Merged
merged 13 commits into from
Jul 18, 2024

Conversation

kohlisid
Copy link
Contributor

@kohlisid kohlisid commented Jul 15, 2024

Fixes #1836

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 54.44%. Comparing base (e042287) to head (cd98820).

Files Patch % Lines
pkg/udf/map_udf.go 0.00% 15 Missing ⚠️
pkg/sdkclient/grpc/grpc_utils.go 0.00% 3 Missing ⚠️
pkg/sdkclient/grpc_resolver/client_resolver.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
+ Coverage   54.35%   54.44%   +0.08%     
==========================================
  Files         284      284              
  Lines       28020    28018       -2     
==========================================
+ Hits        15231    15255      +24     
+ Misses      11874    11851      -23     
+ Partials      915      912       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/udf/map_udf.go Outdated Show resolved Hide resolved
pkg/udf/map_udf.go Show resolved Hide resolved
pkg/udf/map_udf.go Show resolved Hide resolved
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid kohlisid requested a review from whynowy July 15, 2024 21:57
pkg/udf/map_udf.go Outdated Show resolved Hide resolved
Signed-off-by: Sidhant Kohli <[email protected]>
@kohlisid kohlisid requested a review from whynowy July 16, 2024 06:18
@KeranYang KeranYang requested a review from ayildirim21 July 16, 2024 14:29
@kohlisid kohlisid requested a review from whynowy July 16, 2024 19:49
Signed-off-by: Sidhant Kohli <[email protected]>
@vigith vigith marked this pull request as ready for review July 18, 2024 16:20
@vigith vigith enabled auto-merge (squash) July 18, 2024 16:20
Signed-off-by: Sidhant Kohli <[email protected]>
@vigith vigith merged commit 1db0d09 into numaproj:main Jul 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numaflow single-server info for map
5 participants