-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use same server-info file for all map modes #1828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1828 +/- ##
==========================================
+ Coverage 54.35% 54.44% +0.08%
==========================================
Files 284 284
Lines 28020 28018 -2
==========================================
+ Hits 15231 15255 +24
+ Misses 11874 11851 -23
+ Partials 915 912 -3 ☔ View full report in Codecov by Sentry. |
whynowy
reviewed
Jul 15, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
whynowy
reviewed
Jul 16, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
ayildirim21
approved these changes
Jul 16, 2024
whynowy
reviewed
Jul 16, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
whynowy
approved these changes
Jul 16, 2024
vigith
approved these changes
Jul 16, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
yhl25
approved these changes
Jul 18, 2024
Signed-off-by: Sidhant Kohli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1836