Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.md with raw path to YAML #1729

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

tolmanam
Copy link
Contributor

The path to the namespaced-controller-wo-crds.yaml was bringing up the GitLab human-readable file, but I suspect we would prefer to point to the raw YAML

This is just a minor documentation update. I'm not aware of any related issue but noticed a discrepancy when reading over the documentation.1

The path to the `namespaced-controller-wo-crds.yaml` was bringing up the GitLab human-readable file, but I suspect we would prefer to point to the raw YAML

Signed-off-by: Aaron Tolman <[email protected]>
@tolmanam tolmanam marked this pull request as ready for review May 13, 2024 14:03
@tolmanam tolmanam requested review from whynowy and vigith as code owners May 13, 2024 14:03
@syayi
Copy link
Member

syayi commented May 13, 2024

Thanks @tolmanam for fixing the documentation! We (the Numaflow team) would like to know how the community and you use the platform, learn about the use cases, and take some feedback. Would you be open to chatting with us?

Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Using to stable tag will be better.

docs/operations/installation.md Outdated Show resolved Hide resolved
vigith and others added 2 commits May 19, 2024 17:28
Signed-off-by: Vigith Maurice <[email protected]>

Co-authored-by: Derek Wang <[email protected]>
@vigith vigith enabled auto-merge (squash) May 20, 2024 00:29
@vigith vigith merged commit c633b10 into numaproj:main May 20, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants