fix: height fixes to render pipeline view (#1720)

Signed-off-by: veds-g <[email protected]>
numaproj · May 7, 2024 · d2580c6 · d2580c6
1 parent e9810eb
commit d2580c6
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/ui/src/App.css b/ui/src/App.css
@@ -5,6 +5,10 @@ html {
 body,
 #root,
 
+.MuiScopedCssBaseline-root {
+  height: 100%;
+}
+
 .App-side-nav-link {
   text-decoration: none;
   color: inherit;

diff --git a/ui/src/App.tsx b/ui/src/App.tsx
@@ -262,9 +262,7 @@ function App(props: AppProps) {
           setUserInfo,
         }}
       >
-        <ScopedCssBaseline
-          sx={{ height: "100%", fontFamily: "Avenir, sans-serif" }}
-        >
+        <ScopedCssBaseline sx={{ fontFamily: "Avenir, sans-serif" }}>
           <Box
             sx={{
               display: "flex",

diff --git a/ui/src/components/common/SummaryPageLayout/index.tsx b/ui/src/components/common/SummaryPageLayout/index.tsx
@@ -250,7 +250,7 @@ export function SummaryPageLayout({
             width: "14.4rem",
             background: "#F8F8FB",
             boxShadow: "0 0.4rem 0.6rem rgba(39, 76, 119, 0.16)",
-            zIndex: isPlugin ? "auto" : (theme) => theme.zIndex.drawer - 1,
+            zIndex: isPlugin ? 5 : (theme) => theme.zIndex.drawer - 1,
             position: isPlugin ? "relative" : "fixed",
             top: isPlugin ? "3.85rem" : "10.2rem",
             padding: "0 2rem",
@@ -281,7 +281,7 @@ export function SummaryPageLayout({
           minHeight: SUMMARY_HEIGHT,
           background: "#F8F8FB",
           boxShadow: "0 0.3rem 1.1rem rgba(39, 76, 119, 0.16)",
-          zIndex: isPlugin ? "auto" : (theme) => theme.zIndex.drawer - 1,
+          zIndex: isPlugin ? 5 : (theme) => theme.zIndex.drawer - 1,
           position: isPlugin ? "relative" : "fixed",
           top: isPlugin ? "10.5rem" : "9.2rem",
         }}

diff --git a/ui/src/components/plugin/NumaflowMonitorApp/App.css b/ui/src/components/plugin/NumaflowMonitorApp/App.css
@@ -2,6 +2,10 @@ html,
 body,
 #root,
 
+.MuiScopedCssBaseline-root {
+    height: 100%;
+}
+
 .App-side-nav-link {
     text-decoration: none;
     color: inherit;

diff --git a/ui/src/components/plugin/NumaflowMonitorApp/App.tsx b/ui/src/components/plugin/NumaflowMonitorApp/App.tsx
@@ -193,9 +193,7 @@ function App(props: AppProps) {
           setUserInfo,
         }}
       >
-        <ScopedCssBaseline
-          sx={{ height: "100%", fontFamily: "Avenir, sans-serif" }}
-        >
+        <ScopedCssBaseline sx={{ fontFamily: "Avenir, sans-serif" }}>
           <Box
             sx={{
               display: "flex",