Remove clone()
calls from library internals
#91
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
The following API changes were made:
Signer::new()
consumes the givenSecretKey
(fixes ShouldSigner
consumeSecretKey
on creation? #61).KeyFrag::verify()
andCapsuleFrag::verify()
consume the given kfrag/cfrag.KeyFrag::verify()
andCapsuleFrag::verify()
return the original frag on error (as a tuple with the error itself), for logging purposes (since the original object is not available anymore).reencrypt()
consumes the cfrag (but not the capsule, since it wasn't being cloned inside).VerifiedKeyFrag::to_unverified()
andVerifiedCapsuleFrag::to_unverified()
were renamed tounverify()
and consume the corresponding frag.