-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k256 version and use the new functionality #87
Conversation
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
==========================================
+ Coverage 68.44% 68.75% +0.30%
==========================================
Files 16 16
Lines 1334 1344 +10
==========================================
+ Hits 913 924 +11
+ Misses 421 420 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
k256
dependency to 0.10.1 (.1 supportsReduceNonZero<U256>
that we need), and the sub-dependencies accordingly.k256
0.10 requirement)NonZeroCurveScalar
type (a wrapper for the backend type). Fixes Hashing to nonzero scalars #39.ZeroHash
errors were removedNonZeroCurveScalar
so that it could be used transparently in the code. If Add impl ofMul
forNonZeroScalar
*NonZeroScalar
RustCrypto/traits#857 is merged, the impl forNonZeroCurveScalar * NonZeroCurveScalar
can be simplified.SecretBox
in some places to wrap secret data. Filed Rethink zeroization whenZeroizeOnDrop
is available #89 to be fixed whenZeroizeOnDrop
is available.If RustCrypto/elliptic-curves#499 is resolved before this PR is merged (unlikely, but who knows),
NonZeroCurveScalar::invert()
can be simplified.