Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_verification() and to_unverified() to kfrags/cfrags #84

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Dec 20, 2021

Fixes #73

  • adds KeyFrag::skip_verification()
  • adds VerifiedKeyFrag::to_unverified()
  • adds CapsuleFrag::skip_verification()
  • adds VerifiedCapsuleFrag::to_unverified()
  • adds corresponding methods to Python and WASM bindings

@fjarri fjarri added enhancement New feature or request API Related to public API labels Dec 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #84 (3fbc0b6) into master (22645d1) will increase coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
+ Coverage   81.12%   81.15%   +0.02%     
==========================================
  Files          15       15              
  Lines        1118     1125       +7     
==========================================
+ Hits          907      913       +6     
- Misses        211      212       +1     
Impacted Files Coverage Δ
umbral-pre/bench/bench.rs 0.00% <0.00%> (ø)
umbral-pre/src/bench.rs 0.00% <ø> (ø)
umbral-pre/src/capsule_frag.rs 89.58% <66.66%> (-0.49%) ⬇️
umbral-pre/src/key_frag.rs 90.55% <66.66%> (-0.41%) ⬇️
umbral-pre/src/capsule.rs 90.83% <100.00%> (+0.07%) ⬆️
umbral-pre/src/pre.rs 92.30% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22645d1...3fbc0b6. Read the comment docs.

@fjarri fjarri force-pushed the verification-shortcuts branch from adcdd99 to 3fbc0b6 Compare December 20, 2021 00:52
@fjarri fjarri merged commit 3cf47a1 into nucypher:master Dec 20, 2021
@fjarri fjarri deleted the verification-shortcuts branch December 20, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to public API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an unverify()/force_verify() methods to KeyFrag and CapsuleFrag?
2 participants