Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate serde support under a feature #82

Merged
merged 3 commits into from
Dec 19, 2021
Merged

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Dec 19, 2021

serde is a pretty fat crate and is not needed for JS/Python bindings (and possibly not needed by many users of the main crate either). So this PR hides it under an optional feature.

Also it adds a list of available feature to the docs and marks gated methods with a doc attribute.

@fjarri fjarri added the API Related to public API label Dec 19, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2021

Codecov Report

Merging #82 (71df239) into master (f29791c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   81.12%   81.12%           
=======================================
  Files          15       15           
  Lines        1118     1118           
=======================================
  Hits          907      907           
  Misses        211      211           
Impacted Files Coverage Δ
umbral-pre/src/capsule.rs 90.76% <ø> (ø)
umbral-pre/src/capsule_frag.rs 90.07% <ø> (ø)
umbral-pre/src/key_frag.rs 90.96% <ø> (ø)
umbral-pre/src/keys.rs 77.77% <ø> (ø)
umbral-pre/src/pre.rs 92.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29791c...71df239. Read the comment docs.

@fjarri fjarri added the documentation Improvements or additions to documentation label Dec 19, 2021
@fjarri fjarri merged commit 22645d1 into nucypher:master Dec 19, 2021
@fjarri fjarri deleted the serde-as-feature branch December 19, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to public API documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants