Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "num_kfrags" to "shares" #69

Merged
merged 1 commit into from
Sep 12, 2021
Merged

Rename "num_kfrags" to "shares" #69

merged 1 commit into from
Sep 12, 2021

Conversation

fjarri
Copy link
Contributor

@fjarri fjarri commented Sep 4, 2021

Following the standard terminology in nucypher

@fjarri fjarri added the API Related to public API label Sep 4, 2021
@jMyles
Copy link

jMyles commented Sep 4, 2021

What's the story here? We don't like overhead?

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2021

Codecov Report

Merging #69 (fd691e2) into master (3d3adf3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files          14       14           
  Lines        1083     1083           
=======================================
  Hits          892      892           
  Misses        191      191           
Impacted Files Coverage Δ
umbral-pre/src/pre.rs 93.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3adf3...fd691e2. Read the comment docs.

@fjarri
Copy link
Contributor Author

fjarri commented Sep 4, 2021

This just brings the API in sync with the terminology already used in nucypher.

I do like overhead (and #48 is still open), but as I remember from Discord discussions, some people were against it. @derekpierre , for example.

Edit: wasn't Discord, but rather a github comment

@fjarri fjarri added this to the v1.0.0 milestone Sep 4, 2021
@fjarri
Copy link
Contributor Author

fjarri commented Sep 12, 2021

Merging this to keep API synced with the current nucypher terminology. #48 remains open.

Following the standard terminology in `nucypher`
@fjarri fjarri merged commit c0e03ef into nucypher:master Sep 12, 2021
@fjarri fjarri deleted the shares branch September 12, 2021 21:45
This was referenced Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants