Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple wasm-pack targets #60

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Add support for multiple wasm-pack targets #60

merged 2 commits into from
Jul 7, 2021

Conversation

piotr-roslaniec
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec commented Jul 6, 2021 •
edited
Loading

This PR makes it possible to use umbral-pre NPM package both in the browser and on Node.js. This is done using multiple wasm-pack build targets and multiple package.json entry-points:

  "main": "pkg-node/umbral_pre_wasm.js",
  "browser": "pkg-bundler/umbral_pre_wasm.js",
  "types": "umbral_pre_wasm.d.ts"

Other changes:

  • Fixes in example.js
  • Examples for both browser and Node.js

There are a lot of line changes, but these are mostly examples and other boilerplates.

fjarri
fjarri reviewed Jul 6, 2021
View reviewed changes
umbral-pre-wasm/Cargo.toml Outdated Show resolved Hide resolved
@fjarri fjarri merged commit eba7e7f into nucypher:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjarri fjarri fjarri left review comments

@vepkenez vepkenez Awaiting requested review from vepkenez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-roslaniec @fjarri