getrandom: Don't set "wasm-bindgen" #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only supported features of `getrandom` are: - "rdrand" - "js" - "custom" Setting `"wasm-bindgen"` isn't garunteed to work going forward (and does nothing currently). Just to note, your crate is also setting the "js" feature. This is basically saying, "every `wasm32-unknown-unknown` user of this crate is either on Node.js or Client-side Web, and has access to JavaScript". This is a reasonable restriction for your use case, but we always want dependant library crates to be aware of this. Signed-off-by: Joe Richey <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 83.77% 83.77%
=======================================
Files 11 11
Lines 912 912
=======================================
Hits 764 764
Misses 148 148 Continue to review full report at Codecov.
|
|
Thanks for the PR, I am not sure how |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only stable features of
getrandomare:"std""rdrand""js""custom"Setting
"wasm-bindgen"isn't guaranteed to work going forward (and does nothing currently).Just to note, your crate is also setting the
"js"feature. This is basically saying, "everywasm32-unknown-unknownuser of this crate is either on Node.js or Client-side Web, and has access to JavaScript". This is a very reasonable restriction for your use case (as this project seems to have explicit JavaScript bindings), but we always want dependent library crates to be aware of this.Signed-off-by: Joe Richey [email protected]