Tick config #187
Merged
Tick config #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before:
After:
You can now add configuration options "xTickFormat" and "yTickFormat", and these will be interpreted as format specifier strings using d3-format. For examples of this language, see also formatting numbers example. The above examples uses the configuration "xTickFormat": ".2s"This means, use 2 significant digits, and use the SI abbreviations. |
|
After configuring the graph to have fewer tick marks:
There is now new configuration parameters "xTicks" and "yTicks" that specify the approximate number of ticks to be used. This defers to d3.axis.ticks. |
|
@ronakmshah @t00f This is ready for review. |
|
Looks good to me. Thanks @curran |
|
@curran looks good. Will merge. |
This was referenced Nov 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #134 and #133