-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table Sizing #180
Table Sizing #180
Conversation
Here's the current solution: This actually uncovers some upstream errors with our graph sizing in general. Namely:
|
Here's what the final solution looks like: @t00f @ronakmshah This is ready for review and merge. |
Note that this does actually impact all the graphs, by eliminating the 10px padding that was previously applied to all of them. If we want more breathing room inside the graphs, I suggest we do it by modifying their margins. |
Thanks @curran for this work. Looks good. Nit: We need to implement fit to size to the table. Once done, this is good for merging. |
@ronakmshah Thanks for testing, I will try to fix that. |
Looks good. |
Will close #101