Fix settings button visible on insertion settings page #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abestanis
commented
Apr 30, 2023
Abestanis
force-pushed
the
fix/settings_button
branch
from
c9fc4a7 to
2398960
Compare
Abestanis
force-pushed
the
fix/settings_button
branch
from
2398960 to
5fd2825
Compare
nt4f04uNd
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally fixed by #50, but seems to have regressed since then, probably due to a flutter update.
Looks like the dependency on
settingsOpenedwas no longer registered in theinitStatefunction. We work around that by using aStatefulBuilder.It is a bit weird that the goldens on CI did not pick this up in #85, they were showing the button consistently locally.
To make sure this doesn't regress in the future, I also added some tests for the selection route.
This depends on and includes changes from #89 and will be kept as a draft until it is merged.