Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German translation #25

Merged
merged 1 commit into from
May 20, 2022

Conversation

Abestanis
Copy link
Collaborator

@Abestanis Abestanis commented May 5, 2022

Related #10

This adds German translations.

The pull request depends on #24 and should be merged after it, therefore I'm keeping it as a draft. Unfortunately, I cannot set the base branch to the branch of #24, so this pull request contains all commits from that pull request as well. They will disappear, once #24 is merged.

This pull request is ready to be reviewed, the only change is commit 3abee15.

@Abestanis Abestanis force-pushed the feature/translation_de branch from eea4027 to 3abee15 Compare May 5, 2022 17:03
@Abestanis
Copy link
Collaborator Author

@nt4f04uNd I wonder if it would be ok with you to remove the "@..." metadata entries for all translations that are a text type and have no parameters or other metadata. The text type seems to be the default, so these metadata entries are not actually required.

They bloat up the translation files by a lot, making them bigger and harder to navigate.

If you are ok with it, I would remove them from the German translation in this pull request and create a new pull request to remove them in the English and Russian translation files as well.

And while we are on the topic, how do you feel about removing all unused translations? We could always retrieve them later from the git history, if we need them.

@nt4f04uNd nt4f04uNd force-pushed the 1.0.8 branch 3 times, most recently from b91a21f to ca3eadc Compare May 7, 2022 23:17
@nt4f04uNd
Copy link
Owner

It seems fine to remove the unused metadata, but let's first merge #24, so those changes don't add more mess to the review.

Let's keep the unused strings, I kept them to reuse in the future. One day I will review them and delete, when I'm sure they are no longer needed.

@Abestanis
Copy link
Collaborator Author

It seems fine to remove the unused metadata, but let's first merge #24, so those changes don't add more mess to the review.

👍 I will do it in a separate pull request after this one is merged.

@Abestanis Abestanis force-pushed the feature/translation_de branch from 3abee15 to 23909c6 Compare May 20, 2022 20:57
@Abestanis Abestanis marked this pull request as ready for review May 20, 2022 20:57
@nt4f04uNd nt4f04uNd merged commit 376647e into nt4f04uNd:1.0.8 May 20, 2022
@Abestanis Abestanis deleted the feature/translation_de branch May 20, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants