-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update targetSdkVersion #154
Conversation
I launched the app on my device, and apprently, this is not enough Investigating....
|
Ah, this is what nt4f04uNd/audio_service#1 is addressing. FYI #130 also updates the |
I was wondering why this was compiling, I forgot that was a runtime error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unapproving, since we need at least something equivalent to nt4f04uNd/audio_service#1.
On it |
Ah ok, I was hoping you would see #130 (comment). In the future I will @ mention you from the PR description. |
There will be a conflict, sorry. |
Do we also need to update the target sdk version in the plugin at |
Done |
Huh, luckily they allowed me to request more time for the update (until Nov 1), but let's roll it out anyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on an API 34 emulator, works 👍
Co-authored-by: Abestanis <[email protected]>
https://support.google.com/googleplay/android-developer/answer/11926878?hl=en