Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update targetSdkVersion #154

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Update targetSdkVersion #154

merged 5 commits into from
Aug 31, 2024

Conversation

nt4f04uNd
Copy link
Owner

@nt4f04uNd nt4f04uNd assigned Abestanis and unassigned Abestanis Aug 31, 2024
@nt4f04uNd nt4f04uNd requested a review from Abestanis August 31, 2024 15:43
@nt4f04uNd
Copy link
Owner Author

I launched the app on my device, and apprently, this is not enough

Investigating....

D/AndroidRuntime( 4293): Shutting down VM
E/AndroidRuntime( 4293): FATAL EXCEPTION: main
E/AndroidRuntime( 4293): Process: com.nt4f04und.sweyer, PID: 4293
E/AndroidRuntime( 4293): java.lang.RuntimeException: Unable to create service com.ryanheise.audioservice.AudioService: java.lang.SecurityException: com.nt4f04und.sweyer: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts
E/AndroidRuntime( 4293): 	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4664)
E/AndroidRuntime( 4293): 	at android.app.ActivityThread.-$$Nest$mhandleCreateService(Unknown Source:0)
E/AndroidRuntime( 4293): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2264)
E/AndroidRuntime( 4293): 	at android.os.Handler.dispatchMessage(Handler.java:106)
E/AndroidRuntime( 4293): 	at android.os.Looper.loopOnce(Looper.java:205)
E/AndroidRuntime( 4293): 	at android.os.Looper.loop(Looper.java:294)
E/AndroidRuntime( 4293): 	at android.app.ActivityThread.main(ActivityThread.java:8177)
E/AndroidRuntime( 4293): 	at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime( 4293): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
E/AndroidRuntime( 4293): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)
E/AndroidRuntime( 4293): Caused by: java.lang.SecurityException: com.nt4f04und.sweyer: One of RECEIVER_EXPORTED or RECEIVER_NOT_EXPORTED should be specified when a receiver isn't being registered exclusively for system broadcasts
E/AndroidRuntime( 4293): 	at android.os.Parcel.createExceptionOrNull(Parcel.java:3057)
E/AndroidRuntime( 4293): 	at android.os.Parcel.createException(Parcel.java:3041)
E/AndroidRuntime( 4293): 	at android.os.Parcel.readException(Parcel.java:3024)
E/AndroidRuntime( 4293): 	at android.os.Parcel.readException(Parcel.java:2966)
E/AndroidRuntime( 4293): 	at android.app.IActivityManager$Stub$Proxy.registerReceiverWithFeature(IActivityManager.java:5684)
E/AndroidRuntime( 4293): 	at android.app.ContextImpl.registerReceiverInternal(ContextImpl.java:1852)
E/AndroidRuntime( 4293): 	at android.app.ContextImpl.registerReceiver(ContextImpl.java:1792)
E/AndroidRuntime( 4293): 	at android.app.ContextImpl.registerReceiver(ContextImpl.java:1780)
E/AndroidRuntime( 4293): 	at android.content.ContextWrapper.registerReceiver(ContextWrapper.java:755)
E/AndroidRuntime( 4293): 	at com.ryanheise.audioservice.AudioService.onCreate(AudioService.java:367)
E/AndroidRuntime( 4293): 	at android.app.ActivityThread.handleCreateService(ActivityThread.java:4651)
E/AndroidRuntime( 4293): 	... 9 more
E/AndroidRuntime( 4293): Caused by: android.os.RemoteException: Remote stack trace:
E/AndroidRuntime( 4293): 	at com.android.server.am.ActivityManagerService.registerReceiverWithFeature(ActivityManagerService.java:13927)
E/AndroidRuntime( 4293): 	at android.app.IActivityManager$Stub.onTransact(IActivityManager.java:2570)
E/AndroidRuntime( 4293): 	at com.android.server.am.ActivityManagerService.onTransact(ActivityManagerService.java:2720)
E/AndroidRuntime( 4293): 	at android.os.Binder.execTransactInternal(Binder.java:1339)
E/AndroidRuntime( 4293): 	at android.os.Binder.execTransact(Binder.java:1275)
E/AndroidRuntime( 4293):
Connecting to VM Service at ws://127.0.0.1:50662/9wPSvgwATw0=/ws
Lost connection to device.
Exited (sigterm)

@Abestanis
Copy link
Collaborator

Ah, this is what nt4f04uNd/audio_service#1 is addressing. FYI #130 also updates the targetSdkVersion.

@Abestanis
Copy link
Collaborator

I was wondering why this was compiling, I forgot that was a runtime error.

@Abestanis Abestanis self-requested a review August 31, 2024 16:03
Copy link
Collaborator

@Abestanis Abestanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unapproving, since we need at least something equivalent to nt4f04uNd/audio_service#1.

@nt4f04uNd
Copy link
Owner Author

Unapproving, since we need at least something equivalent to nt4f04uNd/audio_service#1.

On it
P.s. please ping me when you do PRs to my forks - I don't get notifications there by default :-)

@Abestanis
Copy link
Collaborator

P.s. please ping me when you do PRs to my forks - I don't get notifications there by default :-)

Ah ok, I was hoping you would see #130 (comment). In the future I will @ mention you from the PR description.

@nt4f04uNd
Copy link
Owner Author

Ah, this is what nt4f04uNd/audio_service#1 is addressing. FYI #130 also updates the targetSdkVersion.

There will be a conflict, sorry.
We need to roll out the update of targetSdkVersion, because today is a deadline for it 💀

pubspec.lock Outdated Show resolved Hide resolved
@Abestanis
Copy link
Collaborator

Do we also need to update the target sdk version in the plugin at sweyer_plugin/android/build.gradle?

@nt4f04uNd
Copy link
Owner Author

Do we also need to update the target sdk version in the plugin at sweyer_plugin/android/build.gradle?

Done

@nt4f04uNd
Copy link
Owner Author

Ah, this is what nt4f04uNd/audio_service#1 is addressing. FYI #130 also updates the targetSdkVersion.

There will be a conflict, sorry. We need to roll out the update of targetSdkVersion, because today is a deadline for it 💀

Huh, luckily they allowed me to request more time for the update (until Nov 1), but let's roll it out anyway

Copy link
Collaborator

@Abestanis Abestanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on an API 34 emulator, works 👍

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Abestanis <[email protected]>
@nt4f04uNd nt4f04uNd merged commit fa2a425 into master Aug 31, 2024
2 checks passed
@nt4f04uNd nt4f04uNd deleted the target-sdk branch August 31, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants