Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Material You monochrome app icon #115

Merged
merged 1 commit into from
May 8, 2023

Conversation

nt4f04uNd
Copy link
Owner

Fixes #112

Снимок экрана 2023-05-06 в 23 12 58

@nt4f04uNd nt4f04uNd requested a review from Abestanis May 6, 2023 17:14
@Abestanis
Copy link
Collaborator

I think since this is an API 31+ feature, we should use a vector image:
ic_launcher_monochrome.zip

But what do you think about keeping the shadow?
ic_launcher_monochrome.zip

Without shadow With shadow
Icon before Icon with shadow

@nt4f04uNd nt4f04uNd force-pushed the feature/112/material-you-icons branch from 8ee9dbb to 763d824 Compare May 8, 2023 17:54
@nt4f04uNd
Copy link
Owner Author

Incredible, thank you! 🔥

Sure, with the shadow it's better.

I tried making it with a shadow, but failed because I used the raw SVG asset.
I now see that you already made such an asset for the splash screen in the past.

Copy link
Collaborator

@Abestanis Abestanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks awesome!

Do you want me to merge the pull requests where you assign me as a reviewer?

@nt4f04uNd
Copy link
Owner Author

Do you want me to merge the pull requests where you assign me as a reviewer?

Actually, now that you have permission to merge PRs, let's leave this to PR author. So I will only approve your PRs.

@nt4f04uNd nt4f04uNd merged commit 08d3568 into master May 8, 2023
@nt4f04uNd nt4f04uNd deleted the feature/112/material-you-icons branch May 8, 2023 20:05
@nt4f04uNd
Copy link
Owner Author

Do you want me to merge the pull requests where you assign me as a reviewer?

Also, I will assign you to all my PRs, if you don't mind.
I enabled master branch protection rule that prevents merging without at least 1 approval.

@Abestanis
Copy link
Collaborator

Yes, perfect. 👍 It's always better to have a second pair of eyes read the code before merging in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Android 13 Material You icons
2 participants